Preserve invalid environment overrides as unspecified

Author: ejsmith

packages/core/src/EventBuilder.ts

@@ -3,14 +3,13 @@ import { Event, EventType, KnownEventDataKeys } from "./models/Event.js";
 import { ManualStackingInfo } from "./models/data/ManualStackingInfo.js";
 import { UserInfo } from "./models/data/UserInfo.js";
 import { EventContext } from "./models/EventContext.js";
-import { isEmpty, normalizeEnvironment, stringify } from "./Utils.js";
+import { isEmpty, stringify } from "./Utils.js";
 import { EventPluginContext } from "./plugins/EventPluginContext.js";
 
 export class EventBuilder {
   public setEnvironment(value: string | null | undefined): EventBuilder {
-    const environment = normalizeEnvironment(value);
-    if (environment) {
-      this.target.environment = environment;
+    if (value != null) {
+      this.target.environment = value;
     } else {
       delete this.target.environment;
     }

packages/core/src/Utils.ts

@@ -563,7 +563,7 @@ export function normalizeEnvironment(value: string | null | undefined): string |
   if (typeof value !== "string") {
     return undefined;
   }
-  const name = value.trim();
+  const name = value.trim().toLowerCase();
   // eslint-disable-next-line no-control-regex -- Deployment names cannot contain control characters.
-  return name && name.length <= 64 && !/[\u0000-\u001f\u007f-\u009f]/u.test(name) ? name.toLowerCase() : undefined;
+  return name && name.length <= 64 && !/[\u0000-\u001f\u007f-\u009f]/u.test(name) ? name : undefined;
 }

packages/core/test/plugins/default/ConfigurationDefaultsPlugin.test.ts

@@ -24,6 +24,14 @@ describe("ConfigurationDefaultsPlugin", () => {
     expect(JSON.parse(JSON.stringify(builder.target)).environment).toBe("staging");
   });
 
+  test.each(["", " ", "x".repeat(65), "prod\ninvalid", "İ".repeat(64)])("should keep invalid override %j unspecified", async (environment) => {
+    const client = new ExceptionlessClient();
+    client.config.environment = "production";
+    const builder = client.createLog("test", "message").setEnvironment(environment);
+    await new ConfigurationDefaultsPlugin().run(new EventPluginContext(client, builder.target, new EventContext()));
+    expect(builder.target.environment).toBeUndefined();
+  });
+
   describe("should add default", () => {
     const userDataKey: string = "user";
     const user = {