Issue summary
Before opening this issue, I have:
Expected behavior
The gem should install.
Actual behavior
The gem does not install because the oj dependency requires C extension support.
Steps to reproduce the problem
- Run
gem install shopify_api on JRuby
Debug logs
$ gem install shopify_api
Fetching oj-3.17.6.gem
Fetching shopify_api-16.3.0.gem
Fetching sorbet-runtime-0.6.13466.gem
Fetching openssl-4.0.2-java.gem
Fetching hash_diff-1.1.1.gem
Fetching httparty-0.24.2.gem
Successfully installed sorbet-runtime-0.6.13466
Successfully installed openssl-4.0.2-java
Building native extensions. This could take a while...
ERROR: Error installing shopify_api:
ERROR: Failed to build gem native extension.
current directory: /Users/headius/work/jruby/lib/ruby/gems/shared/gems/oj-3.17.6/ext/oj
The dependency on oj is both problematic and unnecessary; the json library has been greatly optimized over the past couple of years, and there's little reason to depend upon an external library anymore. Further, json also includes optimized support for JRuby.
I suggest removing the oj dependency and just using json.
Issue summary
Before opening this issue, I have:
shopify_apiversion:[ ] Setlog_level: :debugin my configuration, if applicable[ ] Checked that this isn't an issue with a Shopify APIExpected behavior
The gem should install.
Actual behavior
The gem does not install because the
ojdependency requires C extension support.Steps to reproduce the problem
gem install shopify_apion JRubyDebug logs
The dependency on
ojis both problematic and unnecessary; thejsonlibrary has been greatly optimized over the past couple of years, and there's little reason to depend upon an external library anymore. Further,jsonalso includes optimized support for JRuby.I suggest removing the
ojdependency and just usingjson.