Skip to content

Bug: FileCommand.Cancel() is a no-op that silently does nothing #155

Description

@DaveRMaltby

Summary

FileCommand.Cancel() only logs a debug message and does nothing. Since all operations are synchronous, there is no way to cancel an in-progress command. This is a correctness issue because Cancel() is part of the ADO.NET contract.

Location

  • src/Data.Common/ADO.NET/FileCommand.cs:125-128

Current Behavior

public override void Cancel()
{
    log.LogDebug($"{GetType()}.{nameof(Cancel)} () called.");
}

Impact

  • Long-running queries (e.g., scanning large CSV files) cannot be interrupted
  • CommandTimeout is accepted as a property but never enforced

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdeferredDeferred — not addressing now

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions