Skip to content

Proposal: defer GitHub Actions publish until a platform build completes #117

Description

@han-xudong

Hi, while looking into partial-update dependency conflicts in downstream RoboStack channels, I wondered whether generated GitHub Actions workflows may be publishing a platform too early.

From what I can tell, packages can currently be uploaded while only part of a platform's dependency graph has finished building. For large ROS distributions, that seems likely to expose a partially updated platform state for some period of time.

Would you be open to an optional generator-level mode that defers upload until the full platform build has completed successfully?

A possible approach would be:

  • keep the current behavior as the default
  • add an opt-in mode such as platform-finalize
  • in that mode, batch jobs only build and upload workflow artifacts
  • add a final per-platform publish job that downloads those artifacts and uploads them only after the required build jobs succeed

I have a local prototype in progress that follows this pattern, and it seems compatible with GitHub Actions' documented needs and artifact flow. If this is the wrong layer or there is already a preferred mechanism, I would appreciate the correction.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions