Allow console commands for match manager even when state setting if off

[NicEastvillage]

I would like to use the CycleHUD console command on match start in CleoPetra. However, it only works when state setting is enabled, which I don't want for tournament matches.

I suggest we allow match manager clients to use console commands even when state setting if off.

[swz-git]

It is kind of weird, in my opinion, that console commands are a part of the statesetting packet in the first place. Maybe we could add another packet type that is just a console command and limited to only match managers.

[NicEastvillage]

Yeah, I think the console commands were locked behind state setting because of Set WorldInfo WorldGravityZ and Set WorldInfo TimeDilation which are akin to state setting. Whether a new message type is needed, idk since match manager should also be able to bypass state setting too imo. But it be nice with utility functions that made console commands more convenient for match managers in the interfaces, e.g. a rlbot.runConsoleCommand(...) function.

[VirxEC]

can we have an approved list of cmds when state setting is turned off

[NicEastvillage]

That might require us to do parsing. Fortunately, RL commands are simple to parse. But we might as well allow match managers to just ignore all the restrictions.

[swz-git]

I still like the idea of introducing a separate packet exclusively for console commands allowed only for match managers (and perhaps bots/scripts when statesetting is enabled), deprecating the console commands field in the statesetting packet. If you guys aren't on board with that idea though, I definitely prefer easts suggestion. Parsing console commands might be trivial but it is not a very elegant solution imo.

[NicEastvillage]

I think a new packet type makes sense. It is cleaner that way.

[VirxEC]

I'm confused. If we're making a new msg of approved console commands (enum? i like) why remove the old custom console command list from the state setting msg?

[NicEastvillage]

The new message type is a separate suggestion and does not affect which console commands are allowed. We just find it odd that console commands are in the desired game state message as they have little to do with state setting. Hence, extracting them to a different message would make the API cleaner. We still want them to be locked behind the state setting permission, but to solve the original issue, we add an exception for match managers (clients without agent ids). They should always be able to call console commands (and use state setting).

[NicEastvillage]

See #177