From f616fa97555fbca97dceb02af8d34285e51fa738 Mon Sep 17 00:00:00 2001 From: Frank Hamand Date: Tue, 7 Jul 2026 14:45:07 +0100 Subject: [PATCH] fix(lint): replace non-null assertions failing biome ci on main Two noNonNullAssertion errors were breaking the required `quality` check (`biome ci .`) on main, blocking the merge queue for all PRs: - skills.ts: guard queue.shift() with an early break instead of `!` - agent-server.ts: fall back to Date.now() when barrierReleasedAtMs is unset instead of asserting it non-null Generated-By: PostHog Code Task-Id: 6a70b8ad-752c-451e-bdd6-a4bf178dfe38 --- packages/agent/src/server/agent-server.ts | 5 ++++- packages/workspace-server/src/services/skills/skills.ts | 3 ++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/agent/src/server/agent-server.ts b/packages/agent/src/server/agent-server.ts index ef1be6a671..87bfb8097b 100644 --- a/packages/agent/src/server/agent-server.ts +++ b/packages/agent/src/server/agent-server.ts @@ -1387,7 +1387,10 @@ export class AgentServer { }); this.sessionReadyBootMs = Math.round(process.uptime() * 1000); - this.sessionInitMs = Math.max(0, Date.now() - this.barrierReleasedAtMs!); + this.sessionInitMs = Math.max( + 0, + Date.now() - (this.barrierReleasedAtMs ?? Date.now()), + ); this.logger.debug("Session initialized successfully", { bootMs: this.sessionReadyBootMs, sessionInitMs: this.sessionInitMs, diff --git a/packages/workspace-server/src/services/skills/skills.ts b/packages/workspace-server/src/services/skills/skills.ts index ae90f727bb..9f5db65f0a 100644 --- a/packages/workspace-server/src/services/skills/skills.ts +++ b/packages/workspace-server/src/services/skills/skills.ts @@ -538,7 +538,8 @@ export class SkillsService { const MAX_RESOLVED_SKILLS = 50; while (queue.length > 0) { - const ref = queue.shift()!; + const ref = queue.shift(); + if (!ref) break; const key = `${ref.source}:${ref.path}`; if (seen.has(key)) continue; if (resolved.length >= MAX_RESOLVED_SKILLS) {