Load by scene path breaks on client side

[maxkratt]

Description:
FishNet allows loading a scene by the scene path or name. But if a scene is loaded by its path, it will break on clients and they wont end up loading it; even though it loads fine on the server.
Also, if it's an addressable scene, the client will attempt to only load the scene based off of its name excluding path, causing issues.

Unity version: 6.3

Fish-Networking version: 4.7.2

Discord links:
https://discord.com/channels/424284635074134018/1034477094731784302/1499562980205924382
https://discord.com/channels/424284635074134018/1034477094731784302/1485781934062964820

Example files:
SceneNameIssue.zip

[pumguy]

For a fix of this inconsistency, I changed https://github.com/FirstGearGames/FishNet/blob/4.7.2/Assets/FishNet/Runtime/Managing/Scened/SceneManager.cs#L1104 from broadcastLookupData[i] = new(s); to broadcastLookupData[i] = new(s.handle, lookupData.Name);, and https://github.com/FirstGearGames/FishNet/blob/4.7.2/Assets/FishNet/Runtime/Managing/Scened/SceneManager.cs#L1456 from broadcastLookupData[i] = new(scene); to broadcastLookupData[i] = new(scene.handle, sceneLoadData.SceneLookupDatas[i].Name);. Basically it allows the _sceneProcessor.BeginLoadAsync called with identical parameter on both the sever/host and the client side.
This fix had been use in my personal project for a year without problems (with YooAssets as an alternative solution to Addressables and a custom SceneProcessor), though still need testing to see if it's proper for all other cases.

[EvgenNechyporuk]

string gameScenePath = SceneUtility.GetScenePathByBuildIndex(gameSceneIndex);
string gameSceneName = Path.GetFileNameWithoutExtension(gameScenePath);
SceneLoadData sld = new SceneLoadData(gameSceneName)
{
    ReplaceScenes = ReplaceOption.All
};
networkManager.SceneManager.LoadGlobalScenes(sld);

[FirstGearGames]

Resolved in 4.7.3.

SceneLookupDatas now use the full path excluding the extension.