Bridge MCTP endpoints are not removed after interface is removed

[jinliangw]

mctpd doesn't remove the MCTP endpoints in the EID poll [9,12] after the mctpusb0 interface is removed:

Sep 23 17:59:03 mctpd[4962]: method_setup_endpoint: peer (nil), eid 16, is_bridge 1 ep type 10
Sep 23 17:59:03 mctpd[4962]: Adding route to peer eid 8 net 1 phys physaddr if 28 hw len 0 0x state 0
Sep 23 17:59:03 mctpd[4962]: physaddr if 28 hw len 0 0x requested allocation of pool size = 4
Sep 23 17:59:03 mctpd[4962]: Adding route to peer eid 8 net 1 phys physaddr if 28 hw len 0 0x state 0
Sep 23 17:59:03 mctpd[4962]: mctpd: emitting endpoint add: /au/com/codeconstruct/mctp1/networks/1/endpoints/8
Sep 23 17:59:03 mctpd[4962]: Allocation accepted
Sep 23 17:59:03 mctpd[4962]: Allocated size of 4, starting from EID 9
Sep 23 17:59:03 mctpd[4962]: Bridge (eid 8) assigned pool [9, 12], size 4
Sep 23 17:59:14 mctpd[4962]: mctpd: endpoint_query_addr: receive timed out from sockaddr_mctp_ext eid 9 net 1 type 0x00 if 0 hw len 0 0x
Sep 23 17:59:14 mctpd[4962]: mctpd: Error getting endpoint types for peer eid 9 net 1 phys physaddr if 0 hw len 0 0x state 0. error -110 Connection timed out
Sep 23 17:59:14 mctpd[4962]: mctpd: Returning dbus error 'MCTP Endpoint did not respond', errcode=-110 (Connection timed out)
Sep 23 17:59:14 mctpd[4962]: mctpd: emitting endpoint add: /au/com/codeconstruct/mctp1/networks/1/endpoints/10
Sep 23 17:59:15 mctpd[4962]: mctpd: endpoint_query_addr: receive timed out from sockaddr_mctp_ext eid 11 net 1 type 0x00 if 0 hw len 0 0x
Sep 23 17:59:15 mctpd[4962]: mctpd: Error getting endpoint types for peer eid 11 net 1 phys physaddr if 0 hw len 0 0x state 0. error -110 Connection timed out
Sep 23 17:59:15 mctpd[4962]: mctpd: Returning dbus error 'MCTP Endpoint did not respond', errcode=-110 (Connection timed out)
Sep 23 17:59:15 mctpd[4962]: mctpd: emitting endpoint add: /au/com/codeconstruct/mctp1/networks/1/endpoints/12
Sep 23 17:59:28 mctpd[4962]: Removing local eid 244 net 1
Sep 23 17:59:28 mctpd[4962]: mctpd: emitting endpoint remove: /au/com/codeconstruct/mctp1/networks/1/endpoints/244
Sep 23 17:59:28 mctpd[4962]: Deleting interface #28
Sep 23 17:59:28 mctpd[4962]: mctpd: emitting endpoint remove: /au/com/codeconstruct/mctp1/networks/1/endpoints/8
Sep 23 17:59:28 mctpd[4962]: mctpd: emitting interface remove: /au/com/codeconstruct/mctp1/interfaces/mctpusb0



# busctl tree au.com.codeconstruct.MCTP1
...
        └─ /au/com/codeconstruct/mctp1/networks
          └─ /au/com/codeconstruct/mctp1/networks/1
            └─ /au/com/codeconstruct/mctp1/networks/1/endpoints
              ├─ /au/com/codeconstruct/mctp1/networks/1/endpoints/10
              ├─ /au/com/codeconstruct/mctp1/networks/1/endpoints/12
...

[jk-ozlabs]

I'll take a look. @faizana-nvidia , if you have any preference for an approach for interface removal, let me know.

[faizana-nvidia]

By other issue's description raised by @jinliangw, I get the feeling that downstream endpoints were added via Network.LearEndpoint. Right now we haven't added removal of all downstream peers once our bridge peer is getting removed which is why we see 10 and 12 staying. Nonetheless I have already addressed this part in my commit of other PR (currently under review-rework) f6d091a3b

[jinliangw]

A simple fix may help: #116

[faizana-nvidia]

This has been addressed as part of e80828, we may consider closing this?